Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test and fix macro hygiene #50

Merged
merged 1 commit into from
Feb 10, 2021

Conversation

tommilligan
Copy link
Collaborator

Closes #41

Some macro expansions were not hygenic, and ended up referencing the standard library assert_eq and assert_ne. This was masked in tests by statements such as use pretty_assertions::assert_eq which masked the stdlib macros in tests.

Updated tests to remove these use statements, and audited the existing macro code for non-$crate qualified paths.

@tommilligan tommilligan self-assigned this Feb 10, 2021
@tommilligan tommilligan merged commit de7b965 into rust-pretty-assertions:main Feb 10, 2021
@tommilligan tommilligan deleted the hygenic-macros branch February 10, 2021 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

assert_eq(a,b,) doesn't show pretty printing
1 participant